Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the package SdkType in APIView URI by adding packageType as a new parameter to API review submission requests.
- Added packageType parameter to API review functions to include SdkType metadata
- Updated both direct artifact upload and token file upload methods to pass the packageType
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/Detect-Api-Changes.ps1 | Modified Submit-Request function to accept and pass packageType parameter from package metadata |
| eng/common/scripts/Create-APIReview.ps1 | Updated Upload-SourceArtifact and Upload-ReviewTokenFile functions to include packageType in API requests |
|
The following pipelines have been queued for testing: |
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
Why is this not just part of the PR that adds SdkType to the relevant APIView endpoints?
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
Please simply merge these changes into #12252 to ensure they go in at the same time.
|
@helen229 can you link to the issue we are trying to address with this change? Why do we need to packageType and what is it exactly? Is it mgmt vs data? |
|
This looks like overlap with your other PR I just merged @helen229 should this be closed? |
5 participants
Closes #12242
corresponding PR for API view side changes:
#12398